Skip to content

Error messages cleanup: Don't please the user #7833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2025
Merged

Error messages cleanup: Don't please the user #7833

merged 1 commit into from
Sep 3, 2025

Conversation

fhammerschmidt
Copy link
Member

Avoid the word “please,” except in situations in which the user is asked to do something inconvenient (such as creating a GitHub issue) or the software is to blame for the situation.

Fixes this: #7830 (comment)

@fhammerschmidt fhammerschmidt requested review from cknitt and zth September 3, 2025 08:29
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Sep 3, 2025

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@7833

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@7833

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@7833

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@7833

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@7833

@rescript/runtime

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/runtime@7833

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@7833

commit: 7ca93e1

@fhammerschmidt fhammerschmidt merged commit d911ca6 into master Sep 3, 2025
25 checks passed
@fhammerschmidt fhammerschmidt deleted the unplease branch September 3, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zth zth zth approved these changes

@cknitt cknitt Awaiting requested review from cknitt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fhammerschmidt @zth